Conversation
grod220
force-pushed
the
pod-option-updates
branch
from
345ff64 to
f61cfb4
Compare
grod220
commented
Feb 26, 2026
grod220
force-pushed
the
pod-option-updates
branch
from
f61cfb4 to
93e8a0c
Compare
joncinque
reviewed
Feb 26, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just a few comments to make this a bit more general
grod220
force-pushed
the
pod-option-updates
branch
from
93e8a0c to
83f78e3
Compare
grod220
commented
Feb 27, 2026
joncinque
reviewed
Feb 27, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just one last comment, looks great overall!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #175
spl-podcurrently has two ways to represent optional addresses:optional_keys::OptionalNonZeroPubkeyoption::PodOption<Address>This PR reduces this duplication and aligns on
PodOption<Address>and extends PodOption to fully cover what was deleted in optional_keys:PodOption<Address>